Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow iterable for Vec\concat first argument #496

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Allow iterable for Vec\concat first argument #496

merged 1 commit into from
Sep 30, 2024

Conversation

dragosprotung
Copy link
Contributor

I am not sure why Psl\Vec\concat() only accepts array as the first argument instead of iterable. It seems an oversite. All other function from Psl\Vec allow it and there is nothing special in the implemenation to not support iterable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11109932156

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 98.691%
Files with Coverage Reduction New Missed Lines %
src/Psl/DateTime/Internal/high_resolution_time.php 2 90.48%
Totals Coverage Status
Change from base Build 10847576320: 0.0%
Covered Lines: 5352
Relevant Lines: 5423
💛 - Coveralls

@azjezz azjezz merged commit ecf3aa8 into azjezz:next Sep 30, 2024
15 checks passed
@azjezz azjezz added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels Sep 30, 2024
@azjezz azjezz self-assigned this Sep 30, 2024
@dragosprotung dragosprotung deleted the feature/vec-concat-allow-iterable branch September 30, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragosprotung @coveralls @azjezz