Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelOn regex expressions #22

Closed
tirnovanuaurel opened this issue Jun 3, 2011 · 9 comments
Closed

cancelOn regex expressions #22

tirnovanuaurel opened this issue Jun 3, 2011 · 9 comments
Assignees
Milestone

Comments

@tirnovanuaurel
Copy link

Hi,
I've tried to add regex expressions on cancelOn event but seems that doesn't work.
Example:
cancelOn: 'a[href^="http://"]'
cancelOn: '/http://.\b/'
cancelOn: '((https?|ftp|gopher|telnet|file|notes|ms-help):((//)|(\))+[\w\d:#@%/;$()~
?+-=.&]_)'

Will be a good thing to implement so you can choose elements you want to cancel without using a class.

Also, is it corect that scroll doesn't work over youtube html5 video iframe ? (well embed/object elements).

Best regards,
Aurel Tirnovanu

@tirnovanuaurel
Copy link
Author

Just noticed also on old version(1.4.3) clickling links works without problem, latest 2 versions clicking seems disabled. Don't really know if it's correct or not thu. Talking about iPad(v. 4.2.1).

@azoff
Copy link
Owner

azoff commented Jul 6, 2011

Thanks for this, I will look into it ASAP

@ghost ghost assigned azoff Jul 6, 2011
@azoff
Copy link
Owner

azoff commented Jul 15, 2011

So I just took another look at this and realized that you may not understand the input that cancelOn accepts (hence your desire for a regex). The cancelOn option takes as input anything that the jQuery function takes as input. For more details see the jQuery docs: http://api.jquery.com/jQuery/#jQuery1

I am, however, looking into ways to make click events a bit less cumbersome - more to come soon...

@azoff
Copy link
Owner

azoff commented Jul 15, 2011

All right add some click insulation on commit [master e1b57f7], slated for 1.4.6

@azoff azoff closed this as completed Jul 15, 2011
@tjsnyder
Copy link

It looks like this change can cause problems with the thumb scrolling backwards when the scrolling is drifting from a mouse click. Reverting this change seems to fix it.

@azoff
Copy link
Owner

azoff commented Sep 12, 2011

@tjsnyder can you help me replicate this issue, I can't seem to reproduce this locally - Also any browser information you can part with would be appreciated!

@azoff azoff reopened this Sep 12, 2011
@tjsnyder
Copy link

Safari 5.1
OSX 10.6.8

What happens is that when it drifts, the thumb looks like it is moving in the opposite direction and then 'catches up' to where it should be after it fades away.

Other changes which could be a larger factor, I have line 112 changed from relative to absolute and I am forcing it into vertical scrolling only in the options.

@azoff
Copy link
Owner

azoff commented Sep 13, 2011

Cool, I'll take a look at it as soon as I have a free moment. Thanks!

On Mon, Sep 12, 2011 at 4:52 PM, Timothy Snyder <
[email protected]>wrote:

Safari 5.1
OSX 10.6.8

What happens is that when it drifts, the thumb looks like it is moving in
the opposite direction and then 'catches up' to where it should be after it
fades away.

Other changes which could be a larger factor, I have line 112 changed from
relative to absolute and I am forcing it into vertical scrolling only in the
options.

Reply to this email directly or view it on GitHub:
#22 (comment)

@azoff
Copy link
Owner

azoff commented Sep 26, 2011

So I took another look at it today an here are my findings:

  • On Safari 5.1, OSX - I am seeing performance issues (at least when compared to chrome/webkit/v8), but nothing close to what @tjsnyder is describing. I suspect the behavior he is describing has more to do with the change he made to Overscroll itself (since relative positioning only works in some scenarios).
  • As for the original issue that @tirnovanuaurel had, the "cancelOn" regex seems to be working as designed. As I said with that issue earlier, there may have been confusion about what input it actually takes.
  • Finally, @tjsnyder also mentioned that the scroll seems to be broken on click, but overscroll only works on dragging. Hence, I am led to believe that there must be another plug-in involved or something outside of the scenes that is making this happen.

Simply because these points seem to be inconclusive, I am closing this issue. If something new comes up, let's just create a new issue with clear reproduction steps (like a jsbin example or something) so that there is no confusion.

@azoff azoff closed this as completed Sep 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants