Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VersionMap from upgrade handler #15

Closed
wants to merge 1 commit into from

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Jul 29, 2024

Closes: #XXX

Description

  • fix unchanged module version map issue in v8 upgrade handler

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Jul 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 68.27%. Comparing base (6d3c5c6) to head (d1f9700).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           canto-v8/develop      #15      +/-   ##
====================================================
- Coverage             68.30%   68.27%   -0.04%     
====================================================
  Files                   117      117              
  Lines                 11240    11245       +5     
====================================================
  Hits                   7677     7677              
- Misses                 3088     3093       +5     
  Partials                475      475              
Files Coverage Δ
app/upgrades.go 45.67% <0.00%> (-3.01%) ⬇️

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants