Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix integration tests #17

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Aug 8, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Aug 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.37%. Comparing base (c4c9caa) to head (fa3559a).
Report is 6 commits behind head on canto-v8/develop.

Files with missing lines Patch % Lines
rpc/backend/account_info.go 50.00% 1 Missing ⚠️
rpc/backend/tracing.go 50.00% 0 Missing and 1 partial ⚠️
rpc/backend/tx_info.go 75.00% 1 Missing ⚠️
rpc/types/events.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           canto-v8/develop      #17      +/-   ##
====================================================
+ Coverage             68.30%   68.37%   +0.07%     
====================================================
  Files                   117      117              
  Lines                 11240    11244       +4     
====================================================
+ Hits                   7677     7688      +11     
+ Misses                 3088     3082       -6     
+ Partials                475      474       -1     
Files with missing lines Coverage Δ
app/ante/authz.go 86.95% <100.00%> (ø)
app/ante/fee_checker.go 93.75% <100.00%> (ø)
app/app.go 85.35% <100.00%> (+0.08%) ⬆️
app/upgrades.go 50.00% <ø> (+1.31%) ⬆️
ethereum/eip712/domain.go 100.00% <100.00%> (ø)
ethereum/eip712/eip712_legacy.go 62.62% <100.00%> (ø)
indexer/kv_indexer.go 64.96% <100.00%> (ø)
rpc/backend/blocks.go 85.58% <100.00%> (ø)
rpc/backend/chain_info.go 81.39% <100.00%> (ø)
rpc/types/block.go 50.46% <100.00%> (ø)
... and 10 more

@dudong2 dudong2 force-pushed the patch/integration-tests branch from e4513bd to 16a6884 Compare September 8, 2024 03:45
@dudong2 dudong2 force-pushed the patch/integration-tests branch from 16a6884 to fa3559a Compare September 8, 2024 03:50
@dudong2 dudong2 marked this pull request as ready for review September 20, 2024 06:15
@dudong2 dudong2 merged commit d0d1df0 into canto-v8/develop Sep 20, 2024
18 checks passed
@dudong2 dudong2 deleted the patch/integration-tests branch September 20, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants