Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stories refactoring, i18n <Text /> with separator #40

Merged
merged 3 commits into from
Nov 1, 2018
Merged

Stories refactoring, i18n <Text /> with separator #40

merged 3 commits into from
Nov 1, 2018

Conversation

Drapegnik
Copy link
Member

@Drapegnik Drapegnik commented Oct 14, 2018 •
edited
Loading

add || separator support

from

Выражаем падзяку || Ганне Бучко || (лагатып) і || Даніілу Пячэнка || (саўндтрэк да лекцый).

to

<Text id="about.thanks">
	{(thanks, hanna, forLogo, daniil, forSoundtrack) => (
		<div className="thanks">
        	{thanks}
            <b>{hanna}</b>
            {forLogo}
            <b>{daniil}</b>
            {forSoundtrack}
		</div>
	)}
</Text>

add logging in dev mode

screen shot 2018-10-22 at 00 28 44

refactor stories

screen shot 2018-10-15 at 02 05 31

check out deployed version

@Drapegnik
Copy link
Member Author

(i18n) allow templating / formatting for translations

Drapegnik added a commit that referenced this pull request Oct 21, 2018
@Drapegnik
chore(i18n): add warning logging for missed keys [#40]
6bd7057
@Drapegnik Drapegnik force-pushed the i18n-with-separator branch from 6bd7057 to 049d1e9 Compare October 28, 2018 11:43
Drapegnik added a commit that referenced this pull request Oct 28, 2018
@Drapegnik
fix(i18n): add support for separator in <Text /> [#40]
41d69db
Drapegnik added a commit that referenced this pull request Oct 28, 2018
@Drapegnik
fix(tools): install storybook@alpha, refactor all stories [#40]
b510416
Drapegnik added a commit that referenced this pull request Oct 28, 2018
@Drapegnik
chore(i18n): add warning logging for missed keys [#40]
049d1e9
@Drapegnik Drapegnik force-pushed the i18n-with-separator branch from 049d1e9 to 6458c1d Compare October 30, 2018 21:44
Drapegnik added a commit that referenced this pull request Oct 30, 2018
@Drapegnik
chore(i18n): add warning logging for missed keys [#40]
6458c1d
andemerie
andemerie previously approved these changes Oct 30, 2018
View reviewed changes
@Drapegnik Drapegnik force-pushed the i18n-with-separator branch from 6458c1d to f63779b Compare October 30, 2018 23:16
Drapegnik added a commit that referenced this pull request Oct 30, 2018
@Drapegnik
chore(i18n): add warning logging for missed keys [#40]
f63779b
@Drapegnik
Copy link
Member Author

Drapegnik commented Oct 30, 2018 •
edited
Loading

migrate to storybook@4, patch storybookjs/storybook#4586

@Drapegnik Drapegnik force-pushed the i18n-with-separator branch from f63779b to 60378f3 Compare October 30, 2018 23:24
Drapegnik added a commit that referenced this pull request Oct 30, 2018
@Drapegnik
fix(i18n): add support for separator in <Text /> [#40]
f987897
Drapegnik added a commit that referenced this pull request Oct 30, 2018
@Drapegnik
fix(tools): install storybook@alpha, refactor all stories [#40]
6b0d9f8
Drapegnik added a commit that referenced this pull request Oct 30, 2018
@Drapegnik
chore(i18n): add warning logging for missed keys [#40]
60378f3
@Drapegnik Drapegnik force-pushed the i18n-with-separator branch from 60378f3 to aa64ec6 Compare November 1, 2018 10:47
Drapegnik added a commit that referenced this pull request Nov 1, 2018
@Drapegnik
chore(i18n): add warning logging for missed keys [#40]
aa64ec6
@Drapegnik Drapegnik force-pushed the i18n-with-separator branch from aa64ec6 to a8644f3 Compare November 1, 2018 10:48
@Drapegnik Drapegnik merged commit f952a88 into develop Nov 1, 2018
Drapegnik added a commit that referenced this pull request Nov 1, 2018
@Drapegnik
fix(i18n): add support for separator in <Text /> [#40]
0104a00
Drapegnik added a commit that referenced this pull request Nov 1, 2018
@Drapegnik
fix(tools): install storybook@alpha, refactor all stories [#40]
57a2139
@Drapegnik Drapegnik deleted the i18n-with-separator branch December 8, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andemerie andemerie andemerie left review comments

@UladBohdan UladBohdan Awaiting requested review from UladBohdan

@tyndria tyndria Awaiting requested review from tyndria

Assignees
No one assigned
Labels
✨improvement 🌳refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drapegnik @andemerie