Add git root inside a git repo #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, amazing. I'll check it later |
babarot
added
area/bash
|
Sorry for the late response and thank you for the contribution! Could you fix the conflicts? |
|
Slight request for improvement, can we change it so that it doesn't show if you're at the git root dir? |
hoshsadiq
reviewed
Apr 25, 2020
| @@ -0,0 +1,8 @@ | |||
| __enhancd::entry::git::root() | |||
| { | |||
| if git rev-parse --is-inside-work-tree 2> /dev/null && [[ $(git rev-parse --show-toplevel) != $PWD ]]; then | |||
There was a problem hiding this comment.
I suggest to quote the $(git rev-parse --show-toplevel) and $PWD to prevent issues with spaces in dir/file names
There was a problem hiding this comment.
According to the bash manual,
Word splitting and filename expansion are not performed on the words between the [[ and ]]
So i don't think it's necessary
|
Thanks for the update @gazorby! |
|
Any update on this? |
|
@hoshsadiq We should probably merge #139 first and then come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Inside a git repository (either at root or under sub directories), the list is shifted towards the bottom so the first element become the git root folder of the repository.
Support has been added for both zsh and fish.
WHY
#110