Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AST for the module attribute proposal #11015

Merged
merged 1 commit into from
Jan 17, 2020
Merged

add AST for the module attribute proposal #11015

merged 1 commit into from
Jan 17, 2020

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Jan 15, 2020 •
edited
Loading

Introduce a ImportAttribute structure and add an attributes key on
the ImportDeclaration node.

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@xtuc xtuc added PR: Docs 📝 A type of pull request used for our changelog categories Spec: Import Attributes labels Jan 15, 2020
@xtuc xtuc mentioned this pull request Jan 15, 2020
Merged
nicolo-ribaudo
nicolo-ribaudo approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree with this AST shape proposal.

jridgewell
jridgewell approved these changes Jan 15, 2020
View reviewed changes
packages/babel-parser/ast/spec.md Outdated Show resolved Hide resolved
@xtuc
docs(ast): add AST for the module attribute proposal
724fe3a 
Introduce a `ImportAttribute` structure and add an `attributes` key on
the `ImportDeclaration` node.
@xtuc xtuc force-pushed the sven/module-attribute-ast branch from a2824db to 724fe3a Compare January 16, 2020 15:11
@nicolo-ribaudo nicolo-ribaudo merged commit 34a9653 into master Jan 17, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the sven/module-attribute-ast branch January 17, 2020 19:58
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
This was referenced Feb 24, 2020
Closed
Closed
This was referenced Feb 28, 2020
Open
Merged
This was referenced Mar 7, 2020
Merged
Merged
Merged
Merged
Merged
Open
Open
This was referenced Mar 14, 2020
Merged
Open
Merged
Merged
Open
Open
This was referenced Mar 25, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 2, 2020
Open
Open
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@littledan littledan littledan left review comments

@kaicataldo kaicataldo kaicataldo approved these changes

@JLHwung JLHwung JLHwung approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories Spec: Import Attributes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xtuc @jridgewell @littledan @JLHwung @nicolo-ribaudo @kaicataldo