-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven central version badge should not be prefixed with 'v' #10574
Comments
Shields.io employs the We have several options to consider:
A comprehensive discussion on this topic is already underway in issue #10437. IMO option 3 is best while i think the default should stay with the prefix for now until a standard is set. |
@jNullj Thank you for the comment. I'm not going to go deep into the issue you mentioned. I agree. Adding an option for users to customize the prefix will help. |
+1, this isn't specific to Maven Central badges, I'd like to omit the "v" for PyPI and NPM badges as well. It adds no info, and wastes precious horizontal space on mobile. Obvious solution:
Strange to hard-code the "v" prefix and give no option for overriding. #10437 seems to be much broader / not obviously related. |
adds tests for all options with prefix as well used for badges#2026 but also usefull for usage letting people override v prefix for versions all over the project once badges#2026 is done as requested for example in badges#10574
For historical context I'll also point back to #6135 but regarding 👇
#10437 is directly related, the standardized e.g.
etc. Probably best to read things or at least ask for more direct pointers to related information before pushing back and characterizing something as unrelated |
… cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea github gitlab greasyfork hackage hexpm homebrew itunes jenkins jetbrains jitpack jsr mavenmetadata modrinth nexus npm nuget openvsx opm ore packagist piwheels polymart pub puppetforge pypi ros scoop snapcraft spack spiget thunderstore twitch ubuntu vaadindirectory vcpkg visualstudioappcenter visualstudiomarketplace vpm wordpress] (#10615) * use defaultLabel in renderVersionBadge without tag As we refactor the codebase to use renderVersionBadge. some badges need to show default label regardless of tag existance. This is usefull for cases where the label is dynamic. This change requires fixing test for npm, not sure how it worked before. * Refactor AurVersion to use renderVersionBadge part of #2026 * Refactor CondaVersion to use renderVersionBadge part of #2026 * Refactor WordpressRequiresVersion to use renderVersionBadge * add postfix option to renderVersionBadge * add missing tests for renderVersionBadge add defaultLabel without tag test add postfix test add test for all options together * Refactor WordpressPluginTestedVersion to use renderVersionBadge * add prefix override to renderVersionBadge adds tests for all options with prefix as well used for #2026 but also usefull for usage letting people override v prefix for versions all over the project once #2026 is done as requested for example in #10574 * Refactor RequiresPHPVersionForType to use renderVersionBadge
Are you experiencing an issue with...
shields.io
🐞 Description
I seems the Maven Central Version seems prefix
v
. I don't have any clue for any purpose or intention.e.g.
The
v
doesn't add any value but some confusion.🔗 Link to the badge
No response
💡 Possible Solution
Remove the
v
prefix from the version value.The text was updated successfully, but these errors were encountered: