-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SourceForge] Added badges for SourceForge #9078
Conversation
I don't understand why some tests don't pass. There are no very explicit error messages. |
You can run the core tests locally with |
Oh good! |
🚀 Updated review app: https://pr-9078-badges-shields.fly.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks in pretty decent shape. I've left a few comments but none of it is major
I added the missing |
🚀 Updated review app: https://pr-9078-badges-shields.fly.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for contributing
Thanks for the implementation, but how to generate badges ? Only few of them are - actually - available @ Shields.io... note: license badge would be useful for SourceForge too. |
They are live now. I merged the PR but I hadn't got round to running a deploy immediately |
Hi @forart , I just tested and the merge is now active in the API. You can use Replace BADGE_TYPE by |
This unfortunately has broken existing URLs like |
I made a PR #9101 to add the old API back. Hopefully it will keep the old URLs working |
Changing the endpoints for the existing downloads badges was not intentional. This was my oversight. I should have caught this in review. |
Fix is deployed. Caches should clear in the next few mins |
Hi !
In order to answer issue #8741 I added badges for the SourceForge service:
last-commit
commit-count
languages
contributors
translations
platform
Close #8741