[SourceForge] Add the old API back #9101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #9078 breaks the existing URLs for downloads This commit add the support for the old URLs
|
You can check the diff result of 8d060fd(parent of c2998a2, which breaks the existing URLs) and this PR to see what was changed |
|
Agree with the objective - we broke this by mistake - but we shouldn't duplicate all this code. It only needs a one line change to fix. Closing in favour of #9102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9078 breaks the existing URLs for downloads like this
https://img.shields.io/sourceforge/dt/sevenzip.svgThe API is changed to something like this
https://img.shields.io/sourceforge/downloads/dt/sevenzip.svgThis commit add the support for the old URLs by adding
sourceforge.service.jsandsourceforge.tester.jsback with some modifications to adapt the existingsourceforge-downloads.service.js.