-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom bucket url support for [Scoop] #9984
Conversation
Could you add a parameter description to the
Here's an example of what that looks like: shields/services/github/github-issues-search.service.js Lines 9 to 13 in 8ab9dfa
shields/services/github/github-issues-search.service.js Lines 98 to 103 in 8ab9dfa
|
All done, let me know if there are any issues. |
🚀 Updated review app: https://pr-9984-badges-shields.fly.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thanks 👍
Great first contribution
Closes #9982