feat(endpoint-badge): add logoSize support; test [endpoint] #10132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to jsr-io/jsr
that referenced
this pull request
May 8, 2024
The JSR logo has been added to Simple Icons since simple-icons/simple-icons#10794. I used the `logoSize` parameter to make the logo fit the badge. The feature was introduced at badges/shields#9191. Currently, we can't use `logoSize` in the response due to badges/shields#10132. So I passed these parameters with search parameters instead.
github-merge-queue bot
pushed a commit
to jsr-io/jsr
that referenced
this pull request
May 9, 2024
The JSR logo has been added to Simple Icons since simple-icons/simple-icons#10794. I used the `logoSize` parameter to make the logo fit the badge. The feature was introduced at badges/shields#9191. Currently, we can't use `logoSize` in the response due to badges/shields#10132. So I passed these parameters with search parameters instead.
chris48s
changed the title
|
🚀 Updated review app: https://pr-10132-badges-shields.fly.dev |
|
Can you have a look at getting your test passing? This needs to either
|
chris48s
reviewed
May 20, 2024
| <tr> | ||
| <td><code>logoSize</code></td> | ||
| <td> | ||
| Default: none. Make icons adaptively resize by setting auto. |
There was a problem hiding this comment.
Suggested change
| Default: none. Make icons adaptively resize by setting auto. | |
| Default: none. Make icons adaptively resize by setting <code>auto</code>. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the endpoint badge response schema does not support
logoSizeparameter.