Use XML for Chocolatey, affects [Chocolatey Resharper PowershellGallery] #10344
+12
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
added
bug
|
PyvesB
commented
Jul 9, 2024
| @@ -20,26 +19,11 @@ function createFilter({ packageName, includePrereleases }) { | |||
| const releaseTypeFilter = includePrereleases | |||
| ? 'IsAbsoluteLatestVersion eq true' | |||
| : 'IsLatestVersion eq true' | |||
| return `Id eq '${packageName}' and ${releaseTypeFilter}` | |||
| return `tolower(Id) eq '${packageName.toLowerCase()}' and ${releaseTypeFilter}` | |||
There was a problem hiding this comment.
Case now seems to matter on the Chocolatey API. Without this, our tests based on scriptcs fail, we'd need to use ScriptCs. I'm guessing other users may have relied on case-insensitivity in the past, so this keeps backwards compatibility.
chris48s
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix #10343.
The Chocolatey API seems to have started ignoring our
"Accept": "application/atom+json,application/json"header, and sometimes now returns XML even when we're requesting JSON. The behaviour seems pretty inconsistent, changing slightly the filter parameter in the query can lead to a different format being returned. Switching to XML seems to produce stable results with all the examples I've tried.