-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github all release + all assets total download count #526
Conversation
<br> | ||
<a class='photo' href='https://github.com/sagiegurari'> | ||
<img alt='sagiegurari' src='https://avatars.githubusercontent.com/u/8112599?s=80'> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to put that in try.html, as index.html gets generated from it.
Thanks for contributing! As I explain in the review, I would prefer to merge the URL for this with Could you squash the commits together? |
Thanks for the review. |
I updated based on your comments however, I wasn't 100% sure about github/downloads consolidation, since the URL pattern is different in the current service and wasn't sure if it will catch shorter urls (with less params). camp.route(/^\/github\/downloads\/([^\/]+)\/([^\/]+)\/([^\/]+)\/([^\/]+)\.(svg|png|gif|jpg|json)$/, The added (by me): camp.route(/^\/github\/downloads\/([^\/]+)\/([^\/]+)\.(svg|png|gif|jpg|json)$/, There are also now merge conflicts, so do you need to me merge from your master again? |
due to all the conflicts I recreated the pull request with an up to date repo. |
I think the title says it all.
Basically it helps smaller projects with binary assets to show total downloads of all their releases together.