update docs following token pool changes #8933
Conversation
|
| | shields-io-production | Access management | @calebcartwright, @chris48s, @paulmelnikow | | ||
| | Compose.io Redis | Account owner | @paulmelnikow | | ||
| | Compose.io Redis | Account access | @paulmelnikow | | ||
| | Compose.io Redis | Database connection credentials | @calebcartwright, @chris48s, @paulmelnikow, @pyvesb | |
There was a problem hiding this comment.
Just to clarify what changed here (prettier reformatted the whole table so it is hard to tell), the only change here is I removed the 3 rows about compose.io.
There might be some other things in this table that could do with review but that can be another PR.
|
|
||
| To run the integration tests: | ||
|
|
||
| - You must have Redis installed and in your PATH. Use `brew install redis`, `apt-get install redis`, etc. The test runner will start the server automatically. |
There was a problem hiding this comment.
Do you think it would be worth going ahead and nuking this? Understand it's accurate atm, but I think that's likely to change fairly quickly (guessing your plan is to delete this when we drop the redis portion of the codebase?)
There was a problem hiding this comment.
I think it can be removed when I do #8932
For the moment, if you try to run the integration tests without redis they won't work so I think it is worth keeping it in the docs for the moment
| 2. The server keeps the [resource cache][] in memory. It is neither | ||
| persisted nor inspectable. | ||
|
|
||
| [github auth admin endpoint]: https://github.com/badges/shields/blob/master/services/github/auth/admin.js |
There was a problem hiding this comment.
Ha! Seems like there's been several tentacles from this still lingering around
Co-authored-by: Caleb Cartwright <[email protected]>
Did a quick skim over all the docs relating to token pooling/redis/postgres and made some updates to reflect the current state of play. Tbh I probably should have done some of this in #8922 but I didn't.. so I'm doing it now.