Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

Fix flickering and white spaces on activity list #404

Closed
wants to merge 1 commit into from

Conversation

osdnk
Copy link
Contributor

@osdnk osdnk commented Feb 6, 2019

I have made small research on this issue and unfortunately it appears to be a quite common problem in RN (see e.g. facebook/react-native#21468 and more related) so I tried different approaches, but I do not have a strong opinion if it is what actually solves the problem, but at least make it much less observable.

Following some guides I see that there's no such a great gain from getItemLayout and it behaves not so good with SectionList since calculating offset was not including height of secions' headers (e.g. it's a reason for this lib https://github.com/jsoendermann/rn-section-list-get-item-layout).

This changes are results of my observations and even if it might not be very professional, maybe it's a good step forward?

Final solution might be to add disableVirtualization prop, which solves all the issues, but I believe we don't need it now since it's a great optimisation cost.

@jinchung
Copy link
Contributor

jinchung commented Feb 6, 2019

Followed up with @osdnk and reduced the changes to windowSize for capturing the most gain for removing white sections on fast scroll.

@jinchung jinchung closed this Feb 6, 2019
@jinchung jinchung deleted the fix-transcion-list-flickering branch February 6, 2019 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants