This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
Fix flickering and white spaces on activity list #404
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made small research on this issue and unfortunately it appears to be a quite common problem in RN (see e.g. facebook/react-native#21468 and more related) so I tried different approaches, but I do not have a strong opinion if it is what actually solves the problem, but at least make it much less observable.
Following some guides I see that there's no such a great gain from
getItemLayout
and it behaves not so good withSectionList
since calculating offset was not including height of secions' headers (e.g. it's a reason for this lib https://github.com/jsoendermann/rn-section-list-get-item-layout).This changes are results of my observations and even if it might not be very professional, maybe it's a good step forward?
Final solution might be to add
disableVirtualization
prop, which solves all the issues, but I believe we don't need it now since it's a great optimisation cost.