Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken JSON in one dependency kill all the app #14

Closed
wants to merge 1 commit into from

Conversation

miccarr
Copy link

@miccarr miccarr commented Feb 29, 2016

e.g. angular2 NPM -> ts/package.json

SyntaxError: ./node_modules/angular2/ts/package.json: Unexpected token <

@ImLoaD
Copy link

ImLoaD commented Jul 28, 2016

How long are you going to solve the problem?

mikermcneil added a commit that referenced this pull request Aug 16, 2016
… by default (normally, a failed require should throw-- otherwise you would never know when you had a typo in your Sails app!)
@mikermcneil
Copy link
Member

@miccarr Thanks! For future reference, the behavior here is that, if you had a corrupted dependency in your node_modules folder, then you wouldn't be able to lift Sails until you got rid of it. We added a patch in Sails earlier this year to resolve this.

re: this PR- I can't merge it as-is because it would make debugging difficult for the general case (i.e. if you have a typo in a controller, your controller would go missing instead of showing you a stack trace). But just in case you needed to use include-all directly, I added aignoreRequireFailures option. I don't recommend using it-- but it's a valid use case, so it's in.

@ImLoaD Are you still experiencing an issue? This was fixed back in March by balderdashy/sails@3c03d47#diff-288353a45967ab002f2428b06c42268bR440. If you are, please open an issue in sails with your version info and I'll take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants