Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[implements ACL and S3 response] Add Access Control List option #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Josebaseba
Copy link

@Josebaseba Josebaseba commented Jan 22, 2020

New optional (but really useful) ACL option added 👍

https://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html

And extra attribute is returning now S3 response instead of undefined:

{
  fd: '56c4afec-ec4e-44ce-933b-75dad787168a.jpg',
  size: 44439,
  type: 'image/jpeg',
  filename: 'bj.jpg',
  status: 'finished',
  field: 'image',
  extra:
   { ETag: '"ff10d1b5e2176b9108489d2216f0205a"',
     Location:
      'https://example.s3.amazonaws.com/example/56c4afec-ec4e-44ce-933b-75dad787168a.jpg',
     key: 'demo/56c4afec-ec4e-44ce-933b-75dad787168a.jpg',
     Key: 'demo/56c4afec-ec4e-44ce-933b-75dad787168a.jpg',
     Bucket: 'school-content' } }

Which allows to store the location url, for example, after the upload.

@sailsbot
Copy link
Collaborator

Hi @Josebaseba! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with [proposal], [patch], [fixes #<issue number>], [implements #<other PR number>], or [misc]? Once you've edited it, I'll take another look!

@Josebaseba Josebaseba changed the title Add Access Control List option [implements ACL and S3 response] Add Access Control List option Jan 22, 2020
@sailsbot
Copy link
Collaborator

Hi @Josebaseba! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with [proposal], [patch], [fixes #<issue number>], [implements #<other PR number>], or [misc]? Once you've edited it, I'll take another look!

1 similar comment
@sailsbot
Copy link
Collaborator

Hi @Josebaseba! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with [proposal], [patch], [fixes #<issue number>], [implements #<other PR number>], or [misc]? Once you've edited it, I'll take another look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants