Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update row and update column functions and fix Row values field type #10

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

Chuhaa
Copy link
Contributor

@Chuhaa Chuhaa commented Jul 20, 2021

Purpose

Goals

Fixes https://github.com/wso2-enterprise/choreo/issues/6889

Automation tests

  • Unit tests
    Tested
  • Integration tests
    Tested

Security checks

Samples

 excel:Row|error response = excelClient->updateRow(workbookIdOrPath, "sheetName", "tableName", 4, [[(), (), 8]]);
 excel:Column|error response = excelClient->updateColumn(workbookIdOrPath, "sheetName", "tableName", 1, name = "columnName");

Test environment

SLAlpha 5
JDK 11
Ubuntu 20.04

@Chuhaa Chuhaa changed the title Add update row function Add update row and update column functions Jul 20, 2021
@Chuhaa Chuhaa changed the title Add update row and update column functions Add update row and update column functions and fix Row values field type Jul 20, 2021
excel/client.bal Outdated Show resolved Hide resolved
@LakshanSS
Copy link
Member

Please add licence header in top of all the .bal files

@Chuhaa
Copy link
Contributor Author

Chuhaa commented Jul 21, 2021

Please add licence header in top of all the .bal files

Fixed in 1e5488e. Thanks

@Chuhaa Chuhaa force-pushed the alpha5 branch 4 times, most recently from eab4218 to 9b52b77 Compare July 22, 2021 06:20
@abeykoon abeykoon merged commit f72effc into ballerina-platform:slalpha5 Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants