Convergence issues - SUPERSEDED BY #588 #253
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #588; all changes have now been moved over; will be closed
Once #588 is merged this one can be closed. Do not make changes in this branch. It should forever remain at c453c83
This pull request is dealing with the convergence issues we experienced with big limit orders.
Major changes:
Also added a resources/testing directory; the Jupyter notebook therein is the main source of our research on this topic that underlies those improvement; it also contains unit tests that should be moved to the NBTest area (TODO BEFORE MERGE)