Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence issues - SUPERSEDED BY #588 #253

Closed
wants to merge 5 commits into from
Closed

Conversation

sklbancor
Copy link
Collaborator

@sklbancor sklbancor commented Dec 12, 2023

Superseded by #588; all changes have now been moved over; will be closed

Once #588 is merged this one can be closed. Do not make changes in this branch. It should forever remain at c453c83

This pull request is dealing with the convergence issues we experienced with big limit orders.

Major changes:

  • CPC v3.3.3: as_df, as_dicts (addressed inconsistent naming; old function deprecated but remain)
  • CPC v3.4: added minrw parameter to CPC.from_carbon to allow for different choices of the minimum size of the range

Also added a resources/testing directory; the Jupyter notebook therein is the main source of our research on this topic that underlies those improvement; it also contains unit tests that should be moved to the NBTest area (TODO BEFORE MERGE)

@sklbancor sklbancor force-pushed the convergence branch 9 times, most recently from 41a28d8 to 5a367d8 Compare December 14, 2023 12:35
@zavelevsky zavelevsky changed the base branch from main to develop February 7, 2024 18:05
@sklbancor sklbancor force-pushed the convergence branch 2 times, most recently from f8656e4 to 35c8d11 Compare April 22, 2024 08:32
...

Update BRANCH_CONVERGENCE
Update 202312 ArbBot Convergence.pdf

Update 202312 ArbBot Convergence.pdf
This was referenced Apr 30, 2024
@sklbancor sklbancor changed the title Convergence issues Convergence issues - SUPERSEDED BY #588 Apr 30, 2024
@sklbancor sklbancor closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant