Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default click options per chain #544

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NIXBNT
Copy link
Collaborator

@NIXBNT NIXBNT commented Apr 12, 2024

Addresses #543

Adds a set of default parameters for each supported blockchain to the constants.py

WARNING

  1. These defaults need to be checked thoroughly prior to merge @barakman @Lesigh-3100
  2. In order to use uniswap_v2_forks for the default input of each exchange I was required to remove 'uniswap_v2' from being explicitly added to the forks list (as it doesnt appear on every chain). We need to verify this doesnt have any adverse effects @Lesigh-3100 thoughts? Alternatively, we can go back to specifying each supported exchange explicitly in the defaults

@NIXBNT NIXBNT added the enhancement New feature or request label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants