Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented request pool keeper #24

Merged
merged 8 commits into from
Apr 2, 2021
Merged

Implemented request pool keeper #24

merged 8 commits into from
Apr 2, 2021

Conversation

Benzbeeb
Copy link
Contributor

Fixed: #XXXX

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@Benzbeeb Benzbeeb requested a review from taobun March 11, 2021 09:54
@Benzbeeb Benzbeeb changed the base branch from create-new-msg to master March 17, 2021 10:09
@taobun taobun requested a review from thebevrishot March 19, 2021 03:10
taobun
taobun requested changes Mar 19, 2021
View reviewed changes
x/oracle/types/keys.go Outdated
@@ -1,6 +1,9 @@
package types

import (
"crypto/sha256"
fmt "fmt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt?

x/oracle/types/keys.go Outdated Show resolved Hide resolved
x/oracle/types/keys.go Outdated Show resolved Hide resolved
x/oracle/testapp/setup.go Outdated
@@ -48,9 +48,16 @@ var (

// nolint
var (
Coins1unband = sdk.NewCoins(sdk.NewInt64Coin("uband", 1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unband?

x/oracle/keeper/request_pool.go Show resolved Hide resolved
@Benzbeeb Benzbeeb force-pushed the implement-pool-keeper branch from 25425bd to f122003 Compare April 1, 2021 16:55
@taobun taobun requested a review from ntchjb April 1, 2021 17:00
@taobun taobun merged commit dbb4a63 into master Apr 2, 2021
@taobun taobun deleted the implement-pool-keeper branch May 27, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntchjb ntchjb ntchjb approved these changes

@taobun taobun taobun approved these changes

@thebevrishot thebevrishot Awaiting requested review from thebevrishot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Benzbeeb @ntchjb @taobun