[WIP] align-object-properties - first take WIP #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ported from prettier-miscellaneous (arijs#7 & arijs#8) with some adaptations by @brodybits (Christopher J. Brody <[email protected]>), including: * adapt const shouldBreak = hasNewlineInRange(...) for newer version of prettier * extra comment & spacing * add object to test to ensure that it does not get unwanted padding * adapt tests/align-object-properties/__snapshots__/jsfmt.spec.js.snap for newer version of prettier XXX TODO ITEMS including: * export & check alignObjectProperties option * resolve issue with object partially but not completely defined on the first line Co-authored-by: Joseph Frazier <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
for object partially but not completely defined on the first line (and test it) Co-authored-by: Joseph Frazier <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Joseph Frazier <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
DOES NOT LOOK RIGHT
XXX with cleanup & extra commented logs
options.js & docs Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Joseph Frazier <[email protected]> Co-authored-by: Rafael Hengles <[email protected]> Co-authored-by: Ika <[email protected]> Co-authored-by: Lucas Azzola <[email protected]>
|
Closing in favor of PR #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from
prettier-miscellaneous(arijs#7 & arijs#8), with some major rework by @brodybitswith TODO items:
I suspect there should be a separate option to enable this feature for JSON.