feat: edit group reply #426

y-young · 2023-02-26T09:28:35Z

Tracking: #112

github-actions · 2023-02-26T09:31:16Z

Preview Deployment

Storybook https://pr-426-storybook--bangumi-next.netlify.app

Sites https://pr-426-sites--bangumi-next.netlify.app

codecov · 2023-02-26T09:31:43Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (52c5590) 83.09% compared to head (15f037b) 83.09%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #426   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files          93       93           
  Lines        5388     5390    +2     
  Branches      427      426    -1     
=======================================
+ Hits         4477     4479    +2     
  Misses        904      904           
  Partials        7        7

Impacted Files	Coverage Δ
packages/design/components/Topic/Comment.tsx	`92.24% <100.00%> (+0.06%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

trim21 · 2023-02-26T12:29:55Z

https://pr-426-sites--bangumi-next.netlify.app/group/reply/2177421/edit 试了一下发现能用来修改帖子 b38

API的问题，修好了（

trim21 · 2023-02-27T17:04:27Z

感觉可以改一下 API，直接返回对应的帖子标题，前端就不需要请求两个 API 了

mergify · 2023-03-01T04:31:51Z

@y-young this pull request is now in conflict 😩

mergify · 2023-03-03T05:06:34Z

@y-young this pull request is now in conflict 😩

trim21

等着改一下API的相应，没必要额外请求一次帖子内容。

y-young · 2023-03-07T14:07:22Z

才发现 API 3 天前就改好了(bgm38)

然而现在有个问题，如果用 useGroupTopic 的话必定会请求一次帖子数据，如果不用 useGroupTopic 的话似乎没法让主题里的回复内容在返回之前刷新，试了全局的 mutate 和 useSWRMutation 貌似都不行，刚返回的时候先看到还是旧数据。

trim21 · 2023-03-07T14:22:40Z

才发现 API 3 天前就改好了(bgm38)

然而现在有个问题，如果用 useGroupTopic 的话必定会请求一次帖子数据，如果不用 useGroupTopic 的话似乎没法让主题里的回复内容在返回之前刷新，试了全局的 mutate 和 useSWRMutation 貌似都不行，刚返回的时候先看到还是旧数据。

没有fetch过数据的话直接转跳回去不就能自动fetch新数据了吗？SWR应该是这样的吧？

y-young · 2023-03-07T14:23:56Z

没有fetch过数据的话直接转跳回去不就能自动fetch新数据了吗？SWR应该是这样的吧？

是这样，只不过会看到旧数据变成新数据的过程

trim21 · 2023-03-07T14:28:34Z

没有fetch过数据的话直接转跳回去不就能自动fetch新数据了吗？SWR应该是这样的吧？

是这样，只不过会看到旧数据变成新数据的过程

useGroupTopic 放在提交成功之后？

y-young · 2023-03-08T02:38:23Z

感觉看到旧数据更新到新数据的过程其实问题不大，可以加个 loading mask 解决。

那岂不是得在整个 topic 上加？

FoundTheWOUT · 2023-03-08T02:44:00Z

在最后一行加这样？可能得问问设计师（

Avoid a topic request by not using useGroupTopic Use global mutate to update reply text immediately, revalidate in background

y-young · 2023-03-08T03:31:38Z

应该搞定了，记录一下过程：

如果使用 useSWRMutation 可以避免请求 topic，但昨天测试时无法及时更新 UI，把全局的 cache 打出来后发现是 cache 没有更新，原因是 populateCache 参数默认为 false，改成 true 就可以了

然而使用 useSWRMutation 还有个问题，在编辑回复页 mutate 时会请求一次帖子数据，在跳转回帖子时还会再请求一次，理论上时间相近的两次请求应该会去重，但不知道这里为什么没有

所以现在的方法是用全局的 mutate（避免调用 useGroupTopic），data 参数可以接收一个 mutate 函数，可以对帖子内容进行乐观更新，这样就省去了一次请求，在跳转回帖子后会在后台 revalidate，有问题会 rollback（如果这个请求不需要的话应该也可以去掉）

此外发现 mutate reply 也会发一次请求，现在把 revalidate 改成 false 就不会了

trim21 · 2023-03-09T16:17:10Z

等先合了另一个PR吧，改成error toast

packages/design/components/Topic/__test__/Comment.spec.tsx

packages/website/src/pages/index/group/reply/[id]/edit.tsx

trim21 · 2023-03-11T15:43:25Z

parseInt('12abc') === 12

feat: edit group reply

9cb90e9

pull-request-size bot added the size/M label Feb 26, 2023

mergify bot added the waiting-approval waiting code reviewers to approval PR label Feb 26, 2023

fix: disable reply when there're subreplies

7346fc0

mergify bot added ci:test:fail and removed waiting-approval waiting code reviewers to approval PR labels Feb 27, 2023

fix: test

5e438e6

mergify bot added waiting-approval waiting code reviewers to approval PR and removed ci:test:fail labels Feb 27, 2023

mergify bot added the conflict label Mar 1, 2023

Merge branch 'master' into feat/edit-reply

ba4275e

mergify bot removed the conflict label Mar 1, 2023

mergify bot added the conflict label Mar 3, 2023

Merge branch 'master' into feat/edit-reply

9f17ec8

mergify bot removed the conflict label Mar 3, 2023

trim21 added this to the v0.0.1 milestone Mar 3, 2023

trim21 requested changes Mar 3, 2023

View reviewed changes

trim21 added tracking:blocked:api and removed tracking:blocked:api labels Mar 3, 2023

Merge branch 'master' into feat/edit-reply

d9b76d5

feat: optimistic update reply text

fcf2d53

Avoid a topic request by not using useGroupTopic Use global mutate to update reply text immediately, revalidate in background

Merge branch 'master' into feat/edit-reply

150a7c3

mergify bot added ci:build:fail and removed waiting-approval waiting code reviewers to approval PR labels Mar 9, 2023

fix: error boundary

4f257c8

mergify bot added waiting-approval waiting code reviewers to approval PR and removed ci:build:fail labels Mar 9, 2023

trim21 previously approved these changes Mar 9, 2023

View reviewed changes

Ayase-252 reviewed Mar 10, 2023

View reviewed changes

packages/design/components/Topic/__test__/Comment.spec.tsx Show resolved Hide resolved

Ayase-252 reviewed Mar 10, 2023

View reviewed changes

packages/website/src/pages/index/group/reply/[id]/edit.tsx Outdated Show resolved Hide resolved

fix: parseInt

e51cb08

y-young dismissed trim21’s stale review via e51cb08 March 10, 2023 03:39

Ayase-252 reviewed Mar 10, 2023

View reviewed changes

packages/website/src/pages/index/group/reply/[id]/edit.tsx Outdated Show resolved Hide resolved

fix: parseInt

498d3c9

trim21 and others added 3 commits March 16, 2023 13:58

Merge branch 'master' into feat/edit-reply

f6f1ad1

Merge branch 'master' into feat/edit-reply

829a019

refactor: use error toast

15f037b

trim21 approved these changes Mar 17, 2023

View reviewed changes

trim21 modified the milestones: 0.0.0-alpha.0, next-next, next Mar 19, 2023

y-young requested a review from Ayase-252 March 24, 2023 08:28

Ayase-252 approved these changes Mar 24, 2023

View reviewed changes

mergify bot merged commit facb65f into bangumi:master Mar 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: edit group reply #426

feat: edit group reply #426

y-young commented Feb 26, 2023

github-actions bot commented Feb 26, 2023 •

edited

Loading

codecov bot commented Feb 26, 2023 •

edited

Loading

trim21 commented Feb 26, 2023 •

edited

Loading

trim21 commented Feb 27, 2023

mergify bot commented Mar 1, 2023

mergify bot commented Mar 3, 2023

trim21 left a comment

y-young commented Mar 7, 2023

trim21 commented Mar 7, 2023

y-young commented Mar 7, 2023

trim21 commented Mar 7, 2023

y-young commented Mar 8, 2023

FoundTheWOUT commented Mar 8, 2023

y-young commented Mar 8, 2023 •

edited

Loading

trim21 commented Mar 9, 2023

trim21 commented Mar 11, 2023

feat: edit group reply #426

feat: edit group reply #426

Conversation

y-young commented Feb 26, 2023

github-actions bot commented Feb 26, 2023 • edited Loading

Preview Deployment

codecov bot commented Feb 26, 2023 • edited Loading

Codecov Report

trim21 commented Feb 26, 2023 • edited Loading

trim21 commented Feb 27, 2023

mergify bot commented Mar 1, 2023

mergify bot commented Mar 3, 2023

trim21 left a comment

Choose a reason for hiding this comment

y-young commented Mar 7, 2023

trim21 commented Mar 7, 2023

y-young commented Mar 7, 2023

trim21 commented Mar 7, 2023

y-young commented Mar 8, 2023

FoundTheWOUT commented Mar 8, 2023

y-young commented Mar 8, 2023 • edited Loading

trim21 commented Mar 9, 2023

trim21 commented Mar 11, 2023

github-actions bot commented Feb 26, 2023 •

edited

Loading

codecov bot commented Feb 26, 2023 •

edited

Loading

trim21 commented Feb 26, 2023 •

edited

Loading

y-young commented Mar 8, 2023 •

edited

Loading