Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete group reply #428

Merged
merged 5 commits into from
Mar 3, 2023
Merged

feat: delete group reply #428

merged 5 commits into from
Mar 3, 2023

Conversation

y-young
Copy link
Contributor

@y-young y-young commented Feb 27, 2023

Tracking: #112

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023 •
edited
Loading

Preview Deployment

Storybook https://pr-428-storybook--bangumi-next.netlify.app

Sites https://pr-428-sites--bangumi-next.netlify.app

@mergify mergify bot added the ci:test:fail label Feb 27, 2023
@mergify mergify bot added waiting-approval waiting code reviewers to approval PR and removed ci:test:fail labels Feb 27, 2023
@mergify
Copy link

mergify bot commented Mar 1, 2023

@y-young this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Mar 1, 2023
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Mar 1, 2023
@mergify mergify bot removed the conflict label Mar 1, 2023
@trim21
Copy link
Contributor

trim21 commented Mar 1, 2023

image

@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.17 ⚠️

Comparison is base (ac0d798) 84.02% compared to head (81c47ad) 83.86%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
- Coverage   84.02%   83.86%   -0.17%     
==========================================
  Files          91       91              
  Lines        5271     5286      +15     
  Branches      423      423              
==========================================
+ Hits         4429     4433       +4     
- Misses        836      847      +11     
  Partials        6        6
Impacted Files Coverage Δ
packages/design/components/Topic/Comment.tsx 92.18% <50.00%> (-4.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trim21
Copy link
Contributor

trim21 commented Mar 1, 2023

没事了，刚刚显示的是旧的预览

trim21
trim21 previously approved these changes Mar 1, 2023
View reviewed changes
@trim21 trim21 merged commit 86bc010 into bangumi:master Mar 3, 2023
@y-young y-young deleted the feat/delete-reply branch March 3, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@trim21 trim21 trim21 left review comments

Assignees
No one assigned
Labels
size/XS waiting-approval waiting code reviewers to approval PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-young @trim21 @Ayase-252