Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable labels and annotations on gateway services #77

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

martonsereg
Copy link
Member

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #76
License Apache 2.0

What's in this PR?

Service labels and annotations of ingress and egress gateways are configurable

Why?

To be able to attach special annotations that can configure cloud LBs.

  • Implementation tested (haven't tested with AWS ELBs, only checked that the configured annotations appear on the service)
  • Sample updated

@martonsereg martonsereg requested review from matyix and waynz0r March 2, 2019 08:48
Copy link
Member

@matyix matyix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matyix matyix merged commit bbed406 into master Mar 2, 2019
@matyix matyix deleted the serviceAnnotations branch March 2, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants