Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events to namespace label modifications #813

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Conversation

Laci21
Copy link
Member

@Laci21 Laci21 commented Jan 25, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Record events when istio.io/rev labels are added to or removed from namespaces.

Why?

To help the user understand what happened and why.

Additional context

The events look like this:

default      43s         Normal    IstioInjectionLabelAddition           namespace/laci-test                                          istio.io/rev label added to namespace laci-test, because the namespace has istio.io/rev label in the cluster laci-test, where the ICP cp-v111x is present with the controlplane.istio.servicemesh.cisco.com/namespace-injection-source annotation
default      0s          Normal    IstioInjectionLabelRemoval            namespace/laci-test3                                         istio.io/rev label removed from namespace laci-test3, because the namespace either does not exist or does not have istio.io/rev label in the cluster laci-test, where the ICP cp-v111x is present with the controlplane.istio.servicemesh.cisco.com/namespace-injection-source annotation

Checklist

  • Implementation tested

@Laci21 Laci21 force-pushed the label-removal-event branch from 8d3343c to 6fd7d6c Compare January 25, 2022 17:30
@Laci21 Laci21 merged commit 42095e7 into release-1.11 Jan 26, 2022
@Laci21 Laci21 deleted the label-removal-event branch January 26, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants