Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Probes message to correctly handle IntOrString for 1.17 #902

Merged
merged 3 commits into from
Feb 27, 2023
Merged

add Probes message to correctly handle IntOrString for 1.17 #902

merged 3 commits into from
Feb 27, 2023

Conversation

LuciferInLove
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
API breaks? yes
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Replace k8s core v1.Probes with the new Probes protobuf message to correctly handle IntOrString types

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@LuciferInLove LuciferInLove merged commit ee2ee9a into release-1.17 Feb 27, 2023
@LuciferInLove LuciferInLove deleted the banzaicloud/protoc-fix-1.17 branch February 27, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laci21 Laci21 Laci21 approved these changes

@martonsereg martonsereg Awaiting requested review from martonsereg martonsereg is a code owner

@waynz0r waynz0r Awaiting requested review from waynz0r waynz0r is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuciferInLove @Laci21