-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include go mod vendor to resolve licensei detection failures #907
Conversation
Source link where this solution was discussed: banzaicloud/koperator#853 (comment) |
Opened an issue to improve VCS detection: goph/licensei#44 |
@nishantapatil3 haven't used licensei for a while. If you could open an issue/discussion with some feedback and the latest pain points and what kind of solution you would prefer, it would be helpful. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the approval @Laci21 |
Yes definitely @sagikazarmark! I'll put together few points that can improve licensei 🚀 |
Cherry-pick commit #907 to release-1.16
Cherry-pick commit #907 to release-1.17
What's in this PR?
Include
go mod vendor
stage in github actions to avoid false-positive when modules github repo could not be determinedWhy?
licensei check fails randomly sometimes when github repo license could not be determined
Checklist