Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #919 #920

Merged
merged 2 commits into from
Jun 6, 2023
Merged

fixes #919 #920

merged 2 commits into from
Jun 6, 2023

Conversation

Tanemahuta
Copy link
Contributor

@Tanemahuta Tanemahuta commented May 30, 2023

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? yes
Related tickets fixes #919
License Apache 2.0

What's in this PR?

Changed resource version of HorizontalPodAutoscaler to v2

Why?

Group deprecation in k8s 1.27

Additional context

none

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

- Changed resource version of HorizontalPodAutoscaler to v2
@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

@Tanemahuta
Copy link
Contributor Author

Since the HorizontalPodAutoscaler v2beta2 is deprecated since 1.23, I have taken the shortcut and replaced the group version.

@waynz0r
Copy link
Member

waynz0r commented May 30, 2023

Hi,

I suggest to use the following to be backward compatible:

apiVersion: {{ ternary "autoscaling/v2" "autoscaling/v2beta2" (.Capabilities.APIVersions.Has "autoscaling/v2") }}

@Tanemahuta
Copy link
Contributor Author

Downside: some IDEs (e.g. IntelliJ IDEA in my case) will not properly recognize GVK
If you plan to use beta features and support previous API versions, you might want to create a helper for this.
Pushed a new commit.

Copy link
Contributor

@kristofgyuracz kristofgyuracz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kristofgyuracz kristofgyuracz merged commit 4874d03 into banzaicloud:release-1.17 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal Pod Autoscaler is v2 with k8s 1.26
5 participants