sipsess: allow UPDATE and INFO in early dialog #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilianfridrich
force-pushed
the
update_fixes
branch
from
13f3992 to
c6e618d
Compare
|
This looks fine to me, please merge if this looks okay... |
cspiel1
reviewed
Jul 18, 2023
| @@ -253,7 +253,7 @@ static void target_refresh_handler(struct sipsess_sock *sock, | |||
| return; | |||
| } | |||
|
|
|||
| if (got_offer || is_invite) { | |||
There was a problem hiding this comment.
We think that here a negative reply should be sent if the SDP is not allowed.
Another commit will follow.
cspiel1
reviewed
Jul 18, 2023
| || sess->terminated || sess->awaiting_answer) | ||
| if (!sess || (!sess->established && !sess->refresh_allowed && | ||
| mbuf_get_left(desc)) || sess->terminated || sess->awaiting_answer | ||
| || !sip_dialog_established(sess->dlg)) |
There was a problem hiding this comment.
Please split up this into 2-3 different if-s
cspiel1
reviewed
Jul 18, 2023
src/sipsess/update.c
Outdated
| || sess->awaiting_answer) | ||
| if ((!sess->established && !sess->refresh_allowed | ||
| && mbuf_get_left(sess->desc)) || sess->awaiting_answer | ||
| || !sip_dialog_established(sess->dlg)) |
There was a problem hiding this comment.
Not related. The check is not needed here. The function is not in the API. So we can drop this in another PR.
There was a problem hiding this comment.
Will do.
cspiel1
reviewed
Jul 18, 2023
| if (!desc) { | ||
| err = ENOMEM; | ||
| goto out; | ||
| } |
maximilianfridrich
force-pushed
the
update_fixes
branch
2 times, most recently
from
225257c to
46ea2fa
Compare
maximilianfridrich
force-pushed
the
update_fixes
branch
from
46ea2fa to
c076c9c
Compare
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 3261 section 12.1
This means that UPDATE (or INFO) requests are allowed within early dialogs (RFC 6086 mentions this in section 4.2.1, RFC 3311 in section 5.1).
However, UPDATEs with SDP offers or answers are still only allowed in "early confirmed dialogs" which have been confirmed by a PRACK (see RFCs 3311 and 6337).