Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a r+ comment makes bors think the approval was done twice #149

Open
nagisa opened this issue May 3, 2016 · 0 comments
Open

Editing a r+ comment makes bors think the approval was done twice #149

nagisa opened this issue May 3, 2016 · 0 comments

Comments

@nagisa
Copy link
Contributor

nagisa commented May 3, 2016 •
edited
Loading

If a comment with r+ has been edited then homu will emit

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #,,,

Instead, homu should check that the edit didn’t change the r-state and do nothing if so.
@nagisa nagisa mentioned this issue Jun 2, 2016
Open
alexcrichton pushed a commit to alexcrichton/homu that referenced this issue Mar 19, 2018
Auto merge of barosl#149 - alexrs:testability, r=jdm
2467053 
Refactor parse_commands to add tests.

This PR address servo#143. This is a first step in making Homu testable.

A small refactor has been done, extracting the logic in `parse_commands` to its own functions, to be able to mock the state and add tests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/149)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nagisa