Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homu users can close any PR or Issue of any other Homu enabled project #155

Open
kbknapp opened this issue Mar 31, 2017 · 2 comments
Open

Comments

@kbknapp
Copy link

kbknapp commented Mar 31, 2017

I had a PR in clap-rs/clap#921 that said, "Fixes BurntSushi/ripgrep#426" in order to ping the ripgrep author. Once that PR merged, Homu closed BurntSushi/ripgrep#426 even though I have no rights to the ripgrep project.

IMO Humo should probably check if the issue it's closing is in the same repo (or maybe even just org/owner) as the merging PR.

@sigmavirus24
Copy link

@kbknapp homu was designed for projects that span repositories. I'd expect this behaviour based on that understanding and the understanding that the repository owner for ripgrep set up Homu sometime back and didn't appropriately remove the authorizations.

@kbknapp
Copy link
Author

kbknapp commented Apr 3, 2017

@sigmavirus24 spanning multiple repositories inside a single org/user is fine and makes perfect sense. But crossing organization boundaries (or user boundaries if the repo isn't part of an org) seems wrong. The fact that the ripgrep author didn't remove the Homu authorizations is orthogonal to this issue.

Manishearth added a commit to Manishearth/homu that referenced this issue Jul 27, 2018
Add cfg to parse_commands calls in server.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants