Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-template-compiler version upgrade breaks ember-handlebars-brunch #24

Open
blimmer opened this issue Oct 20, 2014 · 2 comments
Open

Comments

@blimmer
Copy link

blimmer commented Oct 20, 2014

The release of ember-template-compiler 1.9.0-alpha has broken this package. There's already a conversation about this, and it seems that there's a larger conversation on if Ember is at fault for this break or not.

Either way, the package.json of this project should be updated to prevent this issue.

blimmer added a commit to blimmer/ember-handlebars-brunch that referenced this issue Oct 20, 2014
Because 1.9.0-alpha has non-backwards-compatible changes.
Fixes bartsqueezy#24.
@blimmer
Copy link
Author

blimmer commented Oct 24, 2014

If anyone else is experiencing this problem, you can add the following to your package.json

"ember-template-compiler": "1.7.0"

@abobwhite
Copy link

@blimmer I am trying to upgrade my app from Ember 1.5 to 1.9.1 and have been having problems. My brunch builds but it's not compiling templates.

I have these listed in my package.json - any thoughts?

"dependencies": {
    "javascript-brunch": ">= 1.0 < 1.8",
    "coffee-script-brunch": ">= 1.0 < 1.8",
    "css-brunch": ">= 1.0 < 1.8",
    "uglify-js-brunch": ">= 1.0 < 1.8",
    "clean-css-brunch": ">= 1.0 < 1.8",
    "jshint-brunch": ">= 1.6 < 1.8",
    "handlebars": "~2",
    "ember-template-compiler": "git://github.com/toranb/ember-template-compiler.git",
    "sass-brunch": "~1.8.8"
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants