Use caller_locations to reduce memory allocation
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tai Do <[email protected]>
|
Thank you! ❤️ 🎉 |
This was referenced Feb 4, 2024
ghiculescu
reviewed
Jun 19, 2024
| @@ -112,10 +112,12 @@ def self.sidekiq_job | |||
| def self.line | |||
| Marginalia::Comment.lines_to_ignore ||= DEFAULT_LINES_TO_IGNORE_REGEX | |||
|
|
|||
| last_line = caller.detect do |line| | |||
| line !~ Marginalia::Comment.lines_to_ignore | |||
| last_line = caller_locations.detect do |loc| | |||
There was a problem hiding this comment.
@fatkodima before I dive into it... did you ever look at using Thread.each_caller_location in this gem? I know you did in Rails but not sure if there was a reason to not do it here too.
There was a problem hiding this comment.
did you ever look at using
Thread.each_caller_locationin this gem?
I think I don't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137.
Added original author as a coauthor.
cc @byroot