Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3050ユーティリティ機能にシンボリックリンク作成機能する問題を解決 #3063

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix #3050ユーティリティ機能にシンボリックリンク作成機能する問題を解決 #3063

merged 2 commits into from
Jan 31, 2024

Conversation

katokaisya
Copy link
Collaborator

@ryuring
こちら、調整を入れております。
お手数ですが、ご確認お願い申し上げます。

cc @kaburk

ryuring
ryuring requested changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@ryuring ryuring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katokaisya レビュー入れました。よろしくお願いします。

plugins/baser-core/src/Controller/Admin/UtilitiesController.php Outdated Show resolved Hide resolved
plugins/bc-admin-third/templates/Admin/Utilities/index.php Outdated Show resolved Hide resolved
plugins/bc-admin-third/templates/Admin/Utilities/index.php Outdated Show resolved Hide resolved
plugins/bc-admin-third/templates/Admin/Utilities/index.php Outdated Show resolved Hide resolved
@ryuring ryuring added the Reviewed レビュー済 label Jan 23, 2024
@katokaisya
Copy link
Collaborator Author

@ryuring
レビューありがとうございます。
修正しました。

@seto1 seto1 linked an issue Jan 29, 2024 that may be closed by this pull request
【要望】ユーティリティ機能にシンボリックリンク作成機能する問題 #3050
Closed
@ryuring
Copy link
Collaborator

ryuring commented Jan 31, 2024

@katokaisya 全ての修正を確認しました。マージしますね。ありがとうございました。

@ryuring ryuring merged commit cc64772 into baserproject:dev-5 Jan 31, 2024
1 check passed
@ryuring ryuring added this to the 5.0.9 milestone Feb 15, 2024
@ryuring ryuring modified the milestones: 5.0.9, 5.0.10 Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuring ryuring ryuring requested changes

Assignees

@katokaisya katokaisya

Labels
Reviewed レビュー済
Projects
None yet
Milestone
5.0.10
Development

Successfully merging this pull request may close these issues.

【要望】ユーティリティ機能にシンボリックリンク作成機能する問題
2 participants
@katokaisya @ryuring