first/last/nth-child patch for after/before emulation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 7, 2016 17:54
initial nth handler
refactoring
lahmatiy
reviewed
Sep 14, 2016
| // todo возможно есть более простой способ сфлэтить все селекторы из ast | ||
| walk(sourceAst, { | ||
| SimpleSelector: function(token) { | ||
| token.sequence.each(function(part) { |
lahmatiy
reviewed
Sep 14, 2016
| }, | ||
| childClass: { | ||
| template: resource('./template/variant.tmpl'), | ||
| init: function() { | ||
| Node.prototype.init.call(this); | ||
|
|
||
| // копируем объект и сортируем его свойства | ||
| this.condition = sortObject(basis.object.merge(this.condition)); | ||
| this.states = sortObject(basis.object.merge(this.states)); |
There was a problem hiding this comment.
Зачем merge для одного объекта? лучше slice если нужна копия
| var firstToken = token.sequence.head; | ||
|
|
||
| if (firstToken.data.type == 'Class' && firstToken.data.name == this.wrapperClass) { | ||
| token.sequence.remove(token.sequence.first()); |
There was a problem hiding this comment.
если sequence это инстанс List, то тут не будет удаления (вернее будет что-то странное) и нужно .first() -> .head
There was a problem hiding this comment.
unwrap не проверял
надо глянуть )
| walk(resource.AST, { | ||
| SimpleSelector: function(token, parent) { | ||
| token.sequence.each(function(part) { | ||
| var emulators = getAllEmulators(this.emulators); |
There was a problem hiding this comment.
а точно нужно вычислять для каждого новый emulators?
| this.template = this.generator.generate(this.states); | ||
| this.wrapperClass = 'dp-variant-wrapper-' + this.basisObjectId; | ||
| this.resources = this.resources.map(function(resource) { | ||
| return new ProcessableStyleResource({source: resource, useImmediate: true}); |
There was a problem hiding this comment.
пробельчики бы для литеральных объектов { source: .., useImmediate: true }
| @@ -59,7 +72,9 @@ module.exports = function pseudoElementFactory(type, before) { | |||
|
|
|||
| mapper.removeSelector(token); | |||
| allowToEmulate.forEach(function(element) { | |||
| var existingEmulator = element.querySelector(TYPE_NAME); | |||
| var existingEmulator = basis.array.from(element.children).filter(function(child) { | |||
There was a problem hiding this comment.
basis.array.find(..., function(child) {
return child.tagName.toLowerCase() == TYPE_NAME.toLowerCase();
})
| var states = []; | ||
| var state = {}; | ||
|
|
||
| state[type] = false; |
There was a problem hiding this comment.
module.exports = function pseudoClassFactory(type) {
var TYPE_NAME = 'pseudo-class-' + type + '__' + basis.genUID();
var typeState = basis.fn.wrapper(type);
...
var states = [typeState(false), typeState(true)];
smelukov
commented
Sep 14, 2016
| // пропускаем псевдо классы/элементы, иначе querySelectorAll не найдет узлы | ||
| if (sourcePart.type != 'PseudoClass' && sourcePart.type != 'PseudoElement') { | ||
| if ((sourcePart.type != 'PseudoClass' || sourcePart.type == 'PseudoClass' && sourcePart.name == 'first-element') && sourcePart.type != 'PseudoElement') { |
There was a problem hiding this comment.
очень странное место )
переделаю
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.