Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the way to use spawn #142

Closed
wants to merge 1 commit into from
Closed

change the way to use spawn #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion node-phantom-simple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,29 @@ exports.create = function (options, callback) {

args = args.concat([ path.join(__dirname, 'bridge.js') ]);

var phantom = spawn(options.path, args);
var phantom;
// if platform is win32 and the path contains space, using some hacks for the spawn method
if (process.platform == 'win32' && options.path.indexOf(' ') >= 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, execution method on win32 should not depend on path content.

var args = [
"/S",
"/C",
'"',
options.path,
].concat('bridge.js').concat('"');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you fill args in 2 different ways (array definition + concat)?


var command = process.env.comspec || "cmd.exe";

phantom = spawn(
command,
args,
{
windowsVerbatimArguments: true,
cwd: __dirname
}
);
} else {
phantom = spawn(options.path, args);
}

phantom.once('error', function (err) {
callback(err);
Expand Down