Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to generate openapi spec. #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add function to generate openapi spec. #57

wants to merge 1 commit into from
+824 −11

Conversation

The-Podsiadly
Copy link

Built off of @buildpeak's forked PR #41. Added parse_url method to mimic what werkzeug's did. This was copied from flask-restx's PR #463.

bauerji
bauerji requested changes Aug 14, 2022
View reviewed changes
Copy link
Owner

@bauerji bauerji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Please have a look at these comments, than I will try how it works in action

@The-Podsiadly The-Podsiadly force-pushed the feature/41/openapi-docs branch from 43c3cb9 to dfba9ee Compare August 14, 2022 20:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@The-Podsiadly The-Podsiadly requested a review from bauerji August 14, 2022 20:41
@bauerji
Copy link
Owner

bauerji commented Aug 28, 2022

@The-Podsiadly Please, check the linter errors in the tests and modify the code accordingly.

Can you please add some tests for the openapi module? I don't like having such a piece of untested code in the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bauerji bauerji Awaiting requested review from bauerji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The-Podsiadly @bauerji