Hard code dependency resolution bindings for @go_googleapis and WKTs #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* proto.csv is a table that lists Well Known .proto files and all .proto files in @go_googleapis. For each proto import string, it lists the proto_library label, the Go import path, and the go_proto_library label. This was generated using an ad hoc Python script (not included). * Maps are generated from this file and incorporated into the dependency resolution logic in the proto and go extensions. When bazel-contrib#12 is implemented, we can index rules in external repositories, and we won't need this. We need it for now because there's no clear correspondence between proto and Go import strings and the libraries that should be included. Related bazel-contrib/rules_go#1548
jayconrod
force-pushed
the
googleapis-resolve
branch
from
002a239 to
17301f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.proto files in @go_googleapis. For each proto import string, it
lists the proto_library label, the Go import path, and the
go_proto_library label. This was generated using an ad hoc Python
script (not included).
dependency resolution logic in the proto and go extensions.
When #12 is implemented, we can index rules in external repositories,
and we won't need this. We need it for now because there's no clear
correspondence between proto and Go import strings and the libraries
that should be included.
Related bazel-contrib/rules_go#1548