repository_macro directive for referencing macros from WORKSPACE #493
Conversation
|
Thanks for working on this! I'll review as soon as I can, but it might be a couple days. Sorry for the latency -- a lot is happening right now. |
cmd/gazelle/update-repos.go
Outdated
| applyBuildAttributes(c, rules[i]) | ||
| } | ||
| merger.MergeFile(f, nil, rules, merger.PreResolve, kinds) | ||
| if err := f.Save(f.Path); err != nil { |
There was a problem hiding this comment.
What happens if the same file contains multiple macros? It seems like earlier changes would be overwritten here.
There was a problem hiding this comment.
My latest change handles this case in MergeRules by calling rule.SyncMacroFile. It is not the greatest solution, so I am open to other ideas.
blico
force-pushed
the
repositoryMacroDirective
branch
from
02ee6b2 to
1122b00
Compare
blico
force-pushed
the
repositoryMacroDirective
branch
from
1122b00 to
e48258e
Compare
|
(Once again, I apologize for review latency. I'll look at the updates as soon as I can.) |
Looks like it was an import cycle in |
Addresses #483
Added the
repository_macrodirective with the following format:# gazelle:repository_macro repos.bzl%go_repositoriesGazelle only recognizes this directive when reading from the WORKSPACE file.
fix-updateuses the directive to know about rules defined in a macro file, so they can be used during dependency resolution.update-reposcan now update repository rules in the corresponding macros without additional command line arguments instead of writing copies to WORKSPACE.The
to-macroflag functionality has been modified to only write new repository rules to the corresponding macro, and to update existing rules in macros and the WORKSPACE file. However, duplicates will still be written to the macro if the repository rule is not ago_repositoryrule.