language/go: implement minimal module compatibility #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The Go extension now accepts flags -go_repository_mode and -go_repository_module_mode. * The Go extension will emit importpath_aliases attributes for libraries with importpath set if -go_repository_mode was set, Gazelle is in module mode, the prefix is actually a prefix of importpath, the prefix contains a semantic import version suffix, and the prefix was set in the root package. Such a library can be imported with more than one import path. * The minimum version of rules_go is now 0.19.0, since support for importpath_aliases is needed. * When initializing RemoteCache, which is used to resolve external import paths, if we have a known import path that contains a semantic import version suffix, but we don't have a known import path for the path without the suffix, we create an aliases. Also: * Avoided parsing WORKSPACE and related files multiple times when -repo_config is set. Fixes bazel-contrib#477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-go_repository_module_mode.
libraries with importpath set if -go_repository_mode was set,
Gazelle is in module mode, the prefix is actually a prefix of
importpath, the prefix contains a semantic import
version suffix, and the prefix was set in the root package.
Such a library can be imported with more than one import path.
importpath_aliases is needed.
import paths, if we have a known import path that contains a
semantic import version suffix, but we don't have a known import
path for the path without the suffix, we create an aliases.
Also:
-repo_config is set.
Fixes #477