Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: repository directive #651

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Conversation

blico
Copy link
Contributor

@blico blico commented Oct 3, 2019

Implements #132

A repository directive specifies a repository rule that Gazelle should know about. The directive can be repeated multiple times and can be declared from within a macro definition that Gazelle knows about. At the very least the directive must define a rule kind and a name attribute, but it can define extra attributes after that

Copy link
Contributor

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Generally looks good with a few comments below.

repo/repo.go Outdated Show resolved Hide resolved
repo/repo.go Show resolved Hide resolved
repo/repo.go Outdated Show resolved Hide resolved
repo/repo.go Outdated Show resolved Hide resolved
repo/repo.go Show resolved Hide resolved
repo/repo.go Outdated Show resolved Hide resolved
repo/repo.go Show resolved Hide resolved
@jayconrod jayconrod merged commit b65fc45 into bazel-contrib:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants