feat: set login/email on fixed releaser #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
Oct 28, 2022
fmeum
added a commit
to bazel-contrib/rules_go
that referenced
this pull request
Oct 31, 2022
fmeum
added a commit
to fmeum/bazel-gazelle
that referenced
this pull request
Oct 31, 2022
fmeum
added a commit
to bazel-contrib/bazel-gazelle
that referenced
this pull request
Oct 31, 2022
linzhp
pushed a commit
to bazel-contrib/rules_go
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #17
This changes the fixed releaser schema to:
Unless we add more permissions to the app, a user's email can't be fetched unless it's publicly visible on their profile. The result is that the commit on BCR doesn't have an email and could cause some tracking issues for stats in the future.
This adds a way to ensure an email gets set.
This is a breaking API change. However, since Aspect and @fmeum are the only ones using this, we can make the change safely.