gazelle should support updating rules that wrap go_ rules.

[DrMarcII]

For an example, go_web_test_suite wraps go_test, and support all args allowed by go_test (plus additional arguments). If I change a generated go_test rule to go_web_test_suite, gazelle should update that rule.

[pmbethe09]

How would this work? If gazelle is generating a 'go_xxx(name="go_default_yyy", ...' but finds a go_extension_xxx with the same name, it should essentially merge with that rule?

…

On Wed, Feb 15, 2017 at 5:23 PM, Marc Fisher ***@***.***> wrote: For an example, go_web_test_suite <https://github.com/bazelbuild/rules_webtesting/blob/master/web/go.bzl#L20> wraps go_test, and support all args allowed by go_test (plus additional arguments). If I change a generated go_test rule to go_web_test_suite, gazelle should update that rule. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#269>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALF-0tYu87HN0ZUDnG24UQKdEI-a5-7kks5rc3rcgaJpZM4MCU6O> .

[DrMarcII]

Maybe. Although Gazelle has some other related issues in this general area. For e.g., sometimes I want multiple go_test rules to be generated for the same package (see https://github.com/bazelbuild/rules_webtesting/blob/master/go/webtest/BUILD). And I really don't like that it generates the test with name go_default_test (this is related to my dislike to #265)

In general, I want gazelle to be smarter about accepting my edits of the BUILD file and using that to guide what it does.

[pmbethe09]

Note that in 'go test' there is no concept of splitting up your tests in the way that you have done here -- other than the internal versus external test (via _test package). For now, we have chosen to make gazelle compatible with the way that 'go build' and 'go test' operate, which is not as rich as what bazel does.

…

On Tue, Feb 21, 2017 at 5:44 PM, Marc Fisher ***@***.***> wrote: Maybe. Although Gazelle has some other related issues in this general area. For e.g., sometimes I want multiple go_test rules to be generated for the same package (see https://github.com/bazelbuild/ rules_webtesting/blob/master/go/webtest/BUILD). And I really don't like that it generates the test with name go_default_test (this is related to my dislike to #265 <#265>) In general, I want gazelle to be smarter about accepting my edits of the BUILD file and using that to guide what it does. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALF-0p5vjxgFz8PaxTJHJDoYI8sZqFMkks5re2jGgaJpZM4MCU6O> .

[jayconrod]

Closing old issues. Migrated to bazel-contrib/bazel-gazelle#18.