Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the go_sdk.download tag does not support patches #3683

Closed
tyler-french opened this issue Sep 7, 2023 · 0 comments · Fixed by #3684
Closed

the go_sdk.download tag does not support patches #3683

tyler-french opened this issue Sep 7, 2023 · 0 comments · Fixed by #3684

Comments

@tyler-french
Copy link
Contributor

tyler-french commented Sep 7, 2023

What version of rules_go are you using?

0.41.0

What version of gazelle are you using?

0.33.0

What version of Bazel are you using?

6.3.2

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

Linux Amd64

What did you do?

go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(
    version = go_sdk_version,
    goos = "linux",
    goarch = "amd64",
    urls = [
        "https://artifacts.internal/artifactory/go-code/distdir/go/go{}.linux-amd64.mirror6352777.tar.gz".format(go_sdk_version),
    ],
    patches = [
        "//patches:cgo_lookup_unix.patch",
    ],
    patch_strip = 1,
)

What did you expect to see?

Successful build with custom SDK downloaded.

What did you see instead?

ERROR: Analysis of target '//...:go_default_test' failed; build aborted: in tag at /home/user/go-code/MODULE.bazel:56:16, unknown attribute patches provided
@tyler-french tyler-french changed the title the go_sdk.download tag does not support patches the go_sdk.download tag does not support patches Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant