[go_sdk download] allow patches to standard library #3684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Allows users to provide patches to the Go SDK when using the
go_download_sdk
rule or thego_sdk.download
Bzlmod tag.This is helpful when some modification is needed to a package in the go standard library, but the user does not want to manage a fork of the standard library itself.
Since we build the standard library from source, the
patches
should apply appropriately across multiple OS and Architectures. However, we should not expect patches to apply correctly across multipleversion
s of the Go toolchain. For that reason, we only allow patches if the version is specified.Which issues(s) does this PR fix?
Fixes #3683
Testing
Added a test to the BCR which patches the
os
package and then runs a test to assert the patch properly applied.Show that
patches
cannot apply whenversion
is not specified: