-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nogo fails using WORKSPACE.bazel after upgrade to 0.45.0 #3828
Comments
@DolceTriade Do you have a reproducer? Our tests for nogo don't catch this. |
I can't reproduce it in a minimal set up. I'll try some more and see if its something I can reproduce outside of our repository... |
DolceTriade
added a commit
to DolceTriade/monorepo
that referenced
this issue
Jan 13, 2024
nvm, I repro'd it. https://github.com/DolceTriade/monorepo/tree/minimal
The file in that module: // Package mod does a bunch of stuff.
package mod
func Important() {
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of rules_go are you using?
0.45.0
What version of gazelle are you using?
0.35.0
What version of Bazel are you using?
Does this issue reproduce with the latest releases of all the above?
ya
What operating system and processor architecture are you using?
Linux amd64
What did you do?
Upgrade rules_go to 0.45.0 from 0.44.2.
Upon upgrading, nogo fails on things that are wrong and returns garbage output like:
Note that only the file path was replaced, not the file name. Bazel literally returns a random number here. Downgrading to 0.44.2 makes the issue go away.
What did you expect to see?
no nogo failures
What did you see instead?
gibberish nogo failures
The text was updated successfully, but these errors were encountered: