Add GoContext #1140
Merged
Add GoContext #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayconrod
approved these changes
Dec 14, 2017
| ) | ||
| load("@io_bazel_rules_go//go/private:mode.bzl", | ||
| "get_mode", | ||
| load("@io_bazel_rules_go//go/private:context.bzl", #TODO: This ought to be def |
There was a problem hiding this comment.
Any reason not to change this?
There was a problem hiding this comment.
Causes a cycle, because we expose this through def.
If we are willing to break compatability, and not expose this from go:def.bzl we can fix it
go/private/context.bzl
Outdated
| @@ -0,0 +1,219 @@ | |||
| # Copyright 2014 The Bazel Authors. All rights reserved. | |||
go/private/context.bzl
Outdated
| if not stdlib: | ||
| fail("No matching standard library for "+mode_string(mode)) | ||
|
|
||
| members = structs.to_dict(toolchain.actions) |
| "strip": attr.string(mandatory=True), | ||
| # Hidden internal attributes | ||
| "_stdlib_all": attr.label_list(default = _stdlib_all()), | ||
| "_crosstool": attr.label(default=Label("//tools/defaults:crosstool")), |
There was a problem hiding this comment.
I'm surprised this works. Is this implicitly defined by Bazel?
There was a problem hiding this comment.
I think so, it's the same thing we were doing before, except we used to do it on the toolchain.
This collects up all dependancies that were on the toolchain, but shoudld be in target configuration (rather than host) and migrates them to a common go_context_data dependancy. It then adds a GoContext object, that holds the toolchain, build mode, standard library and all mode specific attributes. go_context(ctx) will build one of these and prepare to use it. This simplifies a lot of the logic in the rules, and helps enforce the isolation of action methods from ctx attributes.
jayconrod
reviewed
Dec 15, 2017
| @@ -56,6 +59,9 @@ repository before you call go_register_toolchains_. | |||
| The toolchain | |||
| ~~~~~~~~~~~~~ | |||
|
|
|||
| This a wrapper over the sdk that provides enough extras to match, target and work on a specific | |||
| platforms. It should be considered an opaqute type, you only ever use it through `the context`_. | |||
| The context | ||
| ~~~~~~~~~~~ | ||
|
|
||
| This is the type you use if you are writing custom rules that need |
| @@ -12,6 +12,9 @@ Go toolchains | |||
| .. _register_toolchains: https://docs.bazel.build/versions/master/skylark/lib/globals.html#register_toolchains | |||
| .. _compilation modes: modes.rst#compilation-modes | |||
| .. _go assembly: https://golang.org/doc/asm | |||
| .. _GoLibrary: providers.rst#GoLibrary | |||
There was a problem hiding this comment.
I have no idea why, but GitHub is just showing the raw file instead of rendering it.
| | :param:`resolver` | :type:`function` | :value:`None` | | ||
| +--------------------------------+-----------------------------+-----------------------------------+ | ||
| | This is the function that gets invoked when converting from a GoLibrary to a GoSource. | | ||
| | See resolver_ for a | |
sluongng
added a commit
to sluongng/rules_go
that referenced
this pull request
Jun 28, 2022
`_testmain_library_to_source` was introduced in 1c4f6fd and last usage of this resolver was in 56e5592. ``` > git log -S'_testmain_library_to_source' --oneline 56e5592 Move the test library rule to be go_test internal actions (bazel-contrib#1267) 9031d58 Add GoContext (bazel-contrib#1140) 1c4f6fd Fix aspect based proto builds (bazel-contrib#1131) ``` Let's remove the unused resolver and replace the documentation with the resolver that is actually being used.
linzhp
pushed a commit
that referenced
this pull request
Jul 17, 2022
`_testmain_library_to_source` was introduced in 1c4f6fd and last usage of this resolver was in 56e5592. ``` > git log -S'_testmain_library_to_source' --oneline 56e5592 Move the test library rule to be go_test internal actions (#1267) 9031d58 Add GoContext (#1140) 1c4f6fd Fix aspect based proto builds (#1131) ``` Let's remove the unused resolver and replace the documentation with the resolver that is actually being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collects up all dependancies that were on the toolchain, but shoudld be in
target configuration (rather than host) and migrates them to a common
go_context_data dependancy.
It then adds a GoContext object, that holds the toolchain, build mode, standard
library and all mode specific attributes. go_context(ctx) will build one of
these and prepare to use it.
This simplifies a lot of the logic in the rules, and helps enforce the isolation
of action methods from ctx attributes.