Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/tools/bazel: support bazel.Runfile inside actions #2361

Closed
wants to merge 1 commit into from
Closed

go/tools/bazel: support bazel.Runfile inside actions #2361

wants to merge 1 commit into from

Conversation

jayconrod
Copy link
Contributor

Fixes #2359

@jayconrod jayconrod requested a review from ianthehat as a code owner February 5, 2020 20:31
@jayconrod
Copy link
Contributor Author

Pausing work on this PR for now due to lack of time.

Windows has wildly different behavior of course. For a test, there's a .runfiles directory and no environment variables are set, but the directory contains a manifest file.

@jayconrod
Copy link
Contributor Author

Closing inactive PR. Still lack the time.

@jayconrod jayconrod closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthehat ianthehat Awaiting requested review from ianthehat

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runfiles.go should look at os.Args[0] + ".runfiles" etc.
2 participants
@jayconrod @googlebot